Slowpoke101/FTBLaunch — pull request #882 by romeara (2014-11-25 05:44:37+00:00)
Title: Issue 286 - Show Default Pack Mods in Edit Dialog

I went after [Issue 286](https://github.com/Slowpoke101/FTBLaunch/issues/286) so that people can more easily see what they changed when they edit a mod pack.

Implementation:

- The default mod setup for the pack is looked up from the cached zip file, and the result is stored in an in-memory cache (cache is cleared when the mod is updated).
- If the info can't be found for a mod, the original (current) display is shown.
- The information was presented in the UI by adding the mod name after the jar - and one of the already localized "disabled mod" strings is included if the mod pack comes with that mod disabled
- The additional information is made distinct from the mod file name by making it a different color (Chose orange because it seemed to go with the color scheme already present)
- Mods added by the user have no additional information after them

We may be able to leverage the work done for this in the future to add a "restore to default" button on the edit mod pack screen

A couple screen shots of the result - the "disabled mods" string indicates that the mod is disabled by default:
![enableddisable2](https://cloud.githubusercontent.com/assets/1018131/5178489/e8bafde2-743a-11e4-8b03-4e0d42ebaf54.jpg)
![enableddisabled1](https://cloud.githubusercontent.com/assets/1018131/5178488/e8baa3e2-743a-11e4-8b44-073dee6b71dd.jpg)

I did my best to follow the pull request guidelines - I used the included eclipse formatter and the commit is signed off (assuming I did that correctly)

Couple things that we may wish to change
- Should user-added mods also have text after them? Currently they do not (ejml-0.23 above is an example of this). Not sure if its clear why there is no text or not
- I'm reading from a zip archive at least once per mod (if the user tries to edit it). It seemed to perform fine on my machine, and I think the use of Java7's nio to just look through it quick makes it less concerning, but there might be a better way

(https://github.com/Slowpoke101/FTBLaunch/issues/286)