ripple/ripple-client — pull request #1848 by rht (2014-11-23 07:09:06+00:00)
Title: [TASK] settings: Remove the need for some of the browser force reload

Parameters affected:

1. Options.blobvault.
js/services/oldblob.js
165: var url = Options.blobvault;
180: var url = Options.blobvault;
This should fail because any services/*.js are not re-initialized unless we
do location.reload().
Fix: keep location.reload() intact for blobvault.

js/entry/web.js
243:if (!Options.blobvault) {
244: Options.blobvault = Options.BLOBVAULT_SERVER;
This shouldn't matter because it is independent of the blobvault value.

js/services/id.js
278: if(Options.blobvault) {
This shouldn't matter because it is independent of the blobvault value.

2. Options.bridge.out.bitcoin
src/js/tabs/send.js
147: if (Options.bridge.out.bitcoin) { // And there is a default bridge
148: recipient += '@' + Options.bridge.out.bitcoin;

Test: Change the value in Advanced, then go to Send.
Result: This value updates successfully according to new settings.
3. Options.advanced_feature_switch
js/tabs/trust.js
30: $scope.advanced_feature_switch = Options.advanced_feature_switch;
Test: Change the value in Advanced, then go to Trust.
Result: This value updates successfully according to new settings.

js/tabs/history.js
76: $scope.advanced_feature_switch = Options.advanced_feature_switch;
Test: Change the value in Advanced, then go to History.
Result: This value updates successfully according to new settings.
4. Options.max_tx_network_fee
src/js/services/network.js
30: this.remote.max_fee = Options.max_tx_network_fee || 12;
Test: Change the value in Advanced, then go to any page.
Result: Fails. Because max_tx_network_fee is assigned with pass-by-value.
Fix: Add
$network.remote.max_fee = $scope.options.max_tx_network_fee;
in $scope.saveMaxNetworkFee.
5. Options.server
js/services/network.js
25: this.remote = new ripple.Remote(Options.server, true);
This definitely requires a reload.