Wikia/app — pull request #5423 by Grunny (2014-11-21 10:31:41+00:00)
Title: (CE-1051) Quick fix for caching in SharedHelp

Quick fix for SharedHelp caching which we can improve later when
refactoring the extension.

SharedHelp tries to get the parser cache key from the text it gets
from the help wikia, and use that to save HTTP requests. The string
in the text it is parsing looks like:

Shared help was looking for the string 'end' to find the end of the
cache key. Because this string isn't in that comment, the resulting
parser cache key it would store would look something like
'wikia:pcache:idhash:16', which of course doesn't work. I'm not sure
this ever worked and probably should have been 'and' in the previous
version of the string before we removed the timestamp. This fixes that
parsing so the working parser cache key is stored.

This also removes the timestamp check which was only checking for 10 minutes
and sets the cache entry to 24 hours. We need to bump the cache version to
make sure old stuff uses the new way (mostly for checking if the article exists).

/cc @macbre