mailgun/mailgun-php — pull request #66 by cerealean (2014-11-20 19:42:53+00:00)
Title: PHP DocBlocks, Constants Changes, and Minor Refactors

What I Changed
=============

DocBlocks
-------------
- PHP docblocks have been added to all classes
- This is in reference to this pull request https://github.com/mailgun/mailgun-php/pull/55
- Added link references to class docblocks of Mailgun, MessageBuilder, and BatchMessage

Constants
-------------
- Deleted the Constants file
- Moved the constants from the deleted file to two new classes
- `Mailgun\Constants\Api` for Api related constants
- `Mailgun\Constants\ExceptionMessages` for exception messages
- Refactored other classes that used the old constants to now use the new constant classes
- Messages/Values were not changed
- Did this so that I could create new instances of the MessageBuilder class without going through the Mailgun client. I also feel like it is a little cleaner to "use" classes on the files that will need them.

Minor Refactors
--------------------
- Removed unnecessary constructor
- Removed a function return from `finalize()` method on BatchMessage class. The `sendMessage()` function used does not return anything.
- Removed unused class imports and one unused member variable

Testing
----------
I have tested this locally with simple Mailgun message sending (which was successful). I have also tested with the BatchMessage. Everything seems to be working fine, however *I have not tested all functionality within the package*. The changes I made were minor for the most part, however any feedback or comments from any other eyes would be helpful.

If there are any questions or comments please let me know.