mmbot/mmbot — pull request #176 by jamesbascle (2014-11-17 09:26:48+00:00)
Title: Adding Cleanup Support To NuGet Upgrading

Adding support for the bot itself to store which packages in which directories to delete, and for the wrapper and executable itself to facilitate the deletion of those packages from disk once the bot's AppDomain no longer has a lock on the relevant files.

Tested on our internal mmbot scripts NuGet package, and w/ the HipChat adapter. I also tested under the condition that the reset event gets invoked in some other manner, which would cause the brain to not contain the delete list.

I'm pretty certain the logic is solid. The only thing I can think of that would break it is if a NuGet package does not use a monotonicly increasing versioning scheme, so even YYYYMMDD style versioning should work. It looks like nothing the adapters or my packages are dependent on use anything but SemVer, and that is the standard anyway (NuGet core pretty heavily uses SemVer in it's implementation, with a fallback to other things).

This would resolve #170 and resolve #159.