shoes/shoes4 — pull request #946 by PragTob (2014-11-16 09:24:43+00:00)
Title: Do not count scroll bar into app width

This change is for #580 - finally.

It is rather simple. Before would take non-overlay scrollbars into account when calculating the app width (as theoretically they could disappear and wohooaaa - new space). However, we can't draw on the space where scroll bars are so we'd run into problems. class-book-adjusted.rb creates one flow with width 180 and then figures out the width of the next stack through `width - 180`, which would fail if there are scroll bars present as it'd say that there is more space than there really is.

There is also one commit simply converting java style method calls to ruby style method calls. We decided on that once :)

Last but not least, you'll notice that there is no test yet (and sadly no test broke changing this). I'd like to write a spec, however it seems extraordinarily difficult. Because for all the scroll bar methods we need the `@shell` which means we'd have to stub it out on creation and then stub all methods.
Only thing I can think of is modify the code to use accessors and then stub the accessor before the test. I'll probably give this a shot, otherwise ideas are always welcome.

Off to Brunch!
Tobi