facebook/osquery — pull request #431 by cdown (2014-11-14 23:42:02+00:00)
Title: Add PEP8 and general lint conformance to in-house scripts

My intent in this diff was mostly style linting, so I disabled
non-stylistic pylint linters that fired in the interests of making this
a sane diff with one purpose: stylistic consistency and conformance. If
I disabled them it means they were thrown somewhere and should probably
be looked into some time :-)

This diff adds:
- PEP8 conformance (tested with pep8)
- A cleanup of stuff shown by `pylint`, with quite a few linters
disabled. See above for rationale to disable these -- in the end this
was mostly unused variables, unused imports, etc). These are the
linters I disabled:
- attribute-defined-outside-init
- bad-classmethod-argument
- bare-except
- broad-except
- exec-used
- invalid-name
- logging-not-lazy
- method-hidden
- missing-docstring
- redefined-outer-name
- too-few-public-methods
- too-many-instance-attributes
- too-many-locals
- unused-argument
- flake8 warnings fixed (warnings were about redefinition of previous
variables in a listcomp)

I didn't do anything with git-clang-format since it's from an external
project and it's possible that there may be a wish to merge it in again
later if it gets updated upstream, but you could, of course, apply this
to that script as well if you so wish. Right now it's not at all PEP8
conformant.