po-devs/po-server-goodies — pull request #813 by Fuzzysqurl (2014-11-14 01:26:33+00:00)
Title: Sand Rush Ban + More consistent Tier Check messages

(18:11:40) +Misaka Mikoto: Are you able to script a ban for Sand Rush in XY and ORAS NU

Bans Sand Rush in XY NU and ORAS NU

Groups related bans together, like putting all the ability bans in the same general area, making it easier to find and modify existing bans.

Consistency was more of just formatting every message the same, like weather abilities had 3 different messages, and Drought made changing into monotype display "Smogon UU" as the tier. I did not change Moody for whatever reason, despite it being different from other ability bans. I think it was because Moody's ban message was better at letting the player know which Pokemon specifically was blocking them from the tier and should almost be the standard for all bans. For one of the bans, it said "Dream World" ability for a 6G tier, so I added a small check to display the correct message based on the gen. Finally "Pokemon" had a few different styles so I standardized that.

About half the messages had something along the lines of "change it in the teambuilder" (and they weren't consistent at all) but the other half didn't. When you try to change to like NU with an Ubers Pokemon, it just states that Pokemon is not allowed. I opted for the shorter messages and removed the few instances where it asks you to change it, because that's implied. If you want these back I'll add them to every message, but they seem redundant by saying the same thing in a different way. (See what I did there?)