xbmc/xbmc — pull request #5692 by Memphiz (2014-11-11 19:00:17+00:00)
Title: [vtb] - fix - use the correct bit for signaling the hw decoder to drop a...

... frame. This is the bit which is visible in the now public ios 8 headers of vtb. I doubt that apple ever change this till ios4. If they did - we are screwed on older runtimes. At least on ios6 this bit is valid for sure.

Well i discovered that we were off by one in the kVTDecoderDecodeFlags_DontEmitFrame bit. On ios8 our wrong bit crashed the decoder during seek. I firstly ifdefed the new bit define for only beeing effective on ios8.

Now while looking for a problem on h.264 playback on atv2 (ios6) i realised that using the good bit from ios8 fixes my issue.

That means ... from iso6 to ios8 the bit from this PR is the correct one for signaling the hw decoder to drop frames. For ios5 i will varify. Only risk is ios4. Because of the fact that vtb was private till ios8 apple might have theoretically changed the bit meanings for the hw decoder. But i really doubt it - changing bits would be really bad style.

@davilla a comment?

This fixes a/v sync issue on atv2 and other ios devices which need to drop frames for some reasons (after seek e.x.).