rapid7/metasploit-framework — pull request #4177 by hmoore-r7 (2014-11-11 21:08:26+00:00)
Title: Differentiate failed binds from connects, closes #4169

This change adds two new Rex exceptions and changes the local comm to raise the right one depending on the circumstances. The problem with the existing model is that failed binds and failed connections both raised the same exception. This change is backwards compatible with modules that rescue Rex::AddressInUse in addition to Rex::ConnectionError. There were two corner cases that rescued Rex::AddressInUse specifically:

1. The 'r'-services mixin and modules caught the old exception when handling bind errors. These have been updated to use BindFailed

1. The meterpreter client had a catch for the old exception when the socket reports a bad destination (usually a network connection dropped). This has been updated to use InvalidDestination as that was the intention prior to this change.

Since AddressInUse was part of ConnectionError, modules and mixins which caught both in the same rescue have been updated to just catch ConnectionError.

This includes changes from #4174, but that will land first, and this should merge clean.