udacity/frontend-nanodegree-resume — pull request #7 by betaorbust (2014-11-11 01:29:37+00:00)
Title: <Fix> First pass at making our code up to Udacity FE standards.

First pass at making our code up to our FE standards.

CSS
---------
- Remove extra lines
- Make markup consistent
- Replace font-style:bold with the actual intended markup of font-weight: bold. Now actually works.

HTML
---------
- Closes HTML tag (currently missing)
- Adds title tag, and charset meta. Now is valid HTML.
- Fixes indentation
- Fix getElementById misunderstanding. Was set as ‘== undefined’ .getElementById returns a null, not undefined.
- Fix javascript style for consistency.
- Add comment about loading the page styles to match the rest of the
page.

JS
-----------
- Add missing semicolons.
- Remove extra semicolons.
- Add missing var declarations.
- Remove trailing space.
- Remove object literal quotes.
- Make quotes consistently used.

Open Issues
-----------------
Off the top of my head:
- Lots and lots and lots of globals in helper
- Fry image has copyright protection.
- CSS styles on elements, and ids. Not best practice for quite a while.
- Javascript capitalization inconsistent.
- HTML class/id names capitalization inconsistent.
- body tag has unsupported "unresolved" attribute.

PTAL @nicolasartman