lukecarbis/stock — pull request #1 by lukecarbis (2014-11-10 04:46:24+00:00)
Title: Accessibility

**Accessibility review:**

1) Headings. OK. It's very flat; not really hierarchical in any way, since it's all H1 elements, but they're present, and it isn't an invalid hierarchy.

2) Link text Looks good.

3) Controls Submit button on the search form is hidden using display: none;. It's marginally acceptable to hide the button, but please hide it using the screen-reader-text class, so it's focusable for users of assistive technology. Otherwise, looks good.

4) Keyboard Navigation Main menu is not keyboard navigable at all; no focus, dropdowns receive focus, but do not become visible. Rest of keyboard navigation is fine.

5) Contrasts: Default contrasts look good.

6) Skip links: Looks good.

7) Forms: Labeling is good, other than search button mentioned above.

8) Images: Images are fine. You're using featured images only as background images, so alt attributes don't apply. (You may want to look at the vertical featured image use case, but that's a side issue.)

9) Media: none observed.

10) Disallowed: No disallowed attributes noted.

11) Recommended: ARIA landmark roles: Look good. I also note that you've included aria labels for the roles; these are great, but could be better. Right now, the label isn't programmatically associated with the landmark in any way; there should either be an aria-label attribute on the element itself, or there should be an aria-labelledby attribute that points to the ID value of the label.

12) Recommended: Resizable text: Almost. Page titles that overlay featured images overflow their containers and overlap the sidebar when the text size is increased.

13) Recommended: removal of title attributes: Looks good. I don't see many, at any rate! :)
Overall: it's looking really good; a couple minor issues that need to be fixed, but the menu keyboard focus is a major issue.