benweitzman/BinarySpacePartition — pull request #2 by egasimus (2014-11-07 21:56:23+00:00)
Title: Fixing spacing, and adding a second key binding example.

Hi Ben,

It's a lovely layout that you've put together! It's the staple of my personal xmonad configuration, and it's tremendous help in my day-to-day work. Honestly, with this module, I think XMonad ca put every other WM to shame.

In the beginning, though, I felt it difficult to get my head around the resizing behavior, and this felt quite limiting; at some point I realized that the reason for that was not being able to resize windows upwards. Tonight I finally had time to look into that. Now, I can't say I'm anything else than a Haskell noob, and it'd take me a good while studying your code in order to properly understand how it does its magic, but I followed the general pattern and found where it breaks, so I decided to open a pull request.

What do you know, the fork by @SolitaryCipher implements a new, _"more intuitive" (sic)_ method of resizing on top of yours, probably as a workaround to this as well as a result of the default bindings looking a little alien to someone who expects the second modifier key to toggle between top/bottom or left/right border, rather than between shrinking/expanding... Or maybe that resizing works in a completely different way. I wouldn't know -- can't glean how that works, either. :D In any case, I've added another set of example bindings which implement my preferred behavior -- I assume they could be useful to others.

Cheers,
Adam