google/trace-viewer — pull request #654 by kphanee (2014-11-06 13:55:07+00:00)
Title: Don't show stale category entries in record selection dialog.

PTAL!

The idea of this CL is not to show any stale tracing categories in the record dialog.
Right now, we are adding the categories stored in local storage as well to the list actually received from the Tracer. But the categories stored in local storage might be stale and are no longer present in the tracer object.

I believe we should only use the tv.Settings.get/set for getting the stored value (whether it was selected or un-selected previously) and set the current state accordingly. It should not be appended to the list recieved from the tracer object. WDYT?

This is not a complete patch yet. Few test cases are failing with this change and I will update this CL with the updated test cases, if we are ok with the idea of this CL.