ShopwareAG/shopware-4 — pull request #195 by andrewisplinghoff (2014-11-04 12:48:01+00:00)
Title: Fix newcomer product identification

A customer reported the problem that the newcomer widget is showing wrong products. This error occurs when an order number exists that is equal to an article id that is to be shown in the newcomer widget.

Technical details of the fix:

The sGetPromotionById method accepts both order numbers and article ids. When the article id is passed as a string, the sGetPromotionById interprets the argument as an order number - that is, it tries to find an article with an order number that equals the passed value. Since we are passing an article id to the method and not an order number, we can only ensure correct behaviour by passing the article id as an integer.