adsabs/bumblebee — pull request #153 by aholachek (2014-11-04 18:18:37+00:00)
Title: Marionette 2.2.0

Hi Roman,

Here is the branch using Marionette 2.2.0.

###There were three major changes that I could find:

* The “itemView” option in Collection and CompositeViews has been changed to “childView”, with all the related options changing in name as well ("childViewOptions", "childViewContainer")

* The “close” method has become “destroy”, which is more aggressive in shutting down the view.

* The events that are being triggered changed, initially breaking the functionality, for instance “composite:collection:render” no longer exists as far as I can tell. Other events changed but I can find no instance of them breaking anything.

###There is a single test in facet_widget.spec.js that is still failing, can you take a look and tell me if you have any ideas why?

It's this line :
expect(widget.processFacetResponse.args[1][0].getApiQuery().get('facet.prefix')).to.be.eql(['1/Head, J/']);

###RefreshLogicTooltip
A fair amount of tests broke once I made the changes, some for obvious reasons. However the "refreshLogicTooltip" tests were all failing, and I wasn't sure why (later I realized it was because of the different events). As I looked into it, I realized our default is currently to call the function very redundantly. Just for a single search page render, it was getting called ~500 times (I checked it in the current master and it is the same). So I tried to make it more targeted in the events it responds to, now it is only called ~40 times and everything still seems to be working fine. I think that is the kind of thing that we need to get rid of for performance's sake.