jmmastey/level_up_exercises — pull request #209 by paulh16 (2014-11-03 18:22:38+00:00)
Title: Triangle facts2 pgh - Iteration 2

In this second iteration, I made the following changes:

1. Removeed RADIANS_TO_DEGREES_CONVERSION constant since it is only used once.

2. Refactored the #recite_facts method: extracted a method, #print_triangle_type, that returns a description of the triangle type. (Lines 39-55)

3. Removed the protected accessors for the side instance variables; no need for accessors because these instance variables aren't read from outside the class.

4. Reduced repetition of defining separate methods for #angle_1, #angle_2, and #angle_3. Created a new method, #triangle_angles, that returns an array of the angles, in degrees. As Joe pointed out in our cohort's code review, I probably replaced repetition for a complicated method. Still trying to figure out a better solution for this tradeoff. I also created an instance variable, @angles, for this array.