mozilla/MozStumbler — pull request #1197 by santiago-hollmann (2014-11-04 02:18:27+00:00)
Title:  #893 A minor visual improvement was done on the Drawer.

# Description
The upload reports button was added to the bottom of the Drawer together with the preferences button.

This feature is working on portrait and landscape mode as well (in this case, the the report is scrollable). This bottom buttons on the drawer remain always visible. Below you can find screenshots of both modes.

# Implementation
### Layout design explanation
On the xml file (fragment_metrics_drawer.xml), the ScrollView was moved inside a LinearLayout with vertical orientation.

The only thing that changed on the ScrollView is that now it has a weight of 10.

Below of the ScrollView there is a RelativeLayout (aka "buttons container") which has the upload button and the preferences button. This RelativeLayout has a weight of 1 and its buttons are established one on the left side and the other on the right one according to the bug #893.

Also, following the AC of #893, the preferences menu item was removed.

### Java code explanation
Regarding to the code, the references to the preferences menu item were removed.

Also, the preferences button was added to the MetricsView with its click listener. Besides that, the click listener was removed of the drawer buttons container because when the drawer was open, if you touched the container, the event went directly to the map view which leaded on a wrong behavior.

# Screenshots
![screenshot_2014-11-03-22-40-43](https://cloud.githubusercontent.com/assets/4610807/4893591/2bc907be-63c4-11e4-891e-a9c7e224c325.png)
![screenshot_2014-11-03-22-40-51](https://cloud.githubusercontent.com/assets/4610807/4893592/2bd0adde-63c4-11e4-9e92-9e22e7b82f1c.png)