chapel-lang/chapel — pull request #744 by hildeth (2014-11-04 06:46:40+00:00)
Title: Factor changeRetToArgAndClone()

A further factoring of changeRetToArgAndClone(), to get the constituent functions under a page each.

I also noticed that there were a number of places where reference temps were being inserted "by hand", but this is also done in a sweep at the end of the pass. Letting insertReferenceTemps() handle the insertions saves about 60 lines of code. Note especially the removal of the "else if" clause in insertDestructorCalls(), whose purpose was to supply a reference temp. (This change differs in form from the others.)

[x] Tested with --verify
[x] Tested with --no-local