mongodb/mongo — pull request #851 by stephenwlin (2014-11-01 21:32:58+00:00)
Title: Add missed status return value check

Just noticed this while working on something else: the status returned from `initializeUserPrivilegesFromUserDocument` is being ignored at the end of `AuthorizationManager::_initializeUserFromPrivilegeDocument`.

This could be more succinctly fixed by just changing `return Status::OK()` to `return status`, and I originally did that, but I noticed that another function in the same file (`AuthorizationManager::initialize`) is also doing a similar explicit check, so I figured doing it this was more consistent and less prone to accidental breakage by later changes.

No worries if whoever is reviewing this would prefer to fix this some other way: just wanted to bring it to attention.