CleverRaven/Cataclysm-DDA — pull request #9746 by BevapDin (2014-10-30 14:02:56+00:00)
Title: Fix some display issues

Fixes #6444 - long items names in wish menu (e.g. vacuum-packed salted simpelton ...)

54fd6a5: The uimenu now shortens (if needed) the displayed string and adds an ellipsis.

c345379: Fixes the wish monster menu: the monster "giant black widow spiderling" is 3 cells to long, and the monster description window is one cell to far to the left and overrides the rightmost character of the menu entries.

----

80bf5d6: Fixes #5884 - Long “most damaged part” name, see commit message.

----

f1ca873: Fixes #8508 - actually the issue itself is already fixed, but this fixes the issue in the comment (https://github.com/CleverRaven/Cataclysm-DDA/issues/8508#issuecomment-51733530).

----

5bae765: Fixes the flickering (again, this time for real). To reproduce it:
- narrow sidebar
- stand in front of an impassable square,
- have the visible message log full with messages (there should be text right under the monster radar).
- walk into that impassable square (hold down the key), the character won't move, but the message window flickers.

The live_view thing overrides (and refreshes!) part of the message window, that makes that part blank, than the messages are written to it and it changes back to what was there before the update. This happens in `game::draw_sidebar` where the live_view is hidden (`live_view::hide` is called with `force = true`). This erases (and refreshes) the live_view window even when the window is already hidden. I changed the `force` parameter to `false`, so the window is only erased when it had been shown previously. This has been tested with ncurses and with an SDL build under linux.