refinery/refinerycms — pull request #2728 by CJBrew (2014-10-27 23:10:10+00:00)
Title: Add specs and fix new route

I closed out the previous pull request -- this is now my latest branch.

- Added a bunch of specs and fixed a few deprecation warnings on rspec.
- Create/delete functionality seems to be working well
- After previous discussion about the index/new route I reinstated the index action instead of a redirect route. It's by far the simplest solution -- the :index route simply redirects to :new in the controller.
- Forms can be created with all sorts of parameters and the specs (e.g. for creating an item) don't cover all the different field types that can be added to a model.
- Spam filter feature is broken. If you turn it on via the generator option there will be ~6 failing tests and I don't know what will or won't work!

I'd be happy to work on fixing the spam filter in, but there's a few details about that I really don't understand. e.g.: How can we identify which fields are going to be used for spam filtering? The spam filter seems to have to be customised for any particular model, so perhaps in the case of the form the generator should create only the minimum setup? I don't know what that is!

Chris