jonmak08/yui3 — pull request #11 by zxdgoal (2014-10-21 07:40:05+00:00)
Title: AUI 1741 Browser specific HTML class is not identifying renderer and browser classes properly in IE11

Hey Jon.

I just re-send the same the pull request to make sure you can see my comments :)

One thing I need to confirm with you is that did you run "shifter" before running the "yogi test"?

As the yui.js the test used is the build folder.

The fix is complete from my understanding and the test passes in my local.
```
john@john-Latitude-E6530:~/yui3-master/src/yui$ yogi test
yogi [info] using yogi@0.1.13 on node@0.10.25
yogi [info] using module: yui
yogi [info] prepping grover tests
yogi [info] adding tests route
yogi [info] launching xdr server on port 5001
yogi [info] listening on: http://127.0.0.1:5000
yogi [info] starting cli tests for: yui

YUITest@0.7.9
SS.S........S...S..S.yogi [ERROR] yuitest: error: (attach-error): Attach error: attach-error
.....SSSSS.yogi [ERROR] yuitest: warn: (yui): NOT loaded: no-such-module
yogi [ERROR] yuitest: warn: (yui): NOT loaded: no-such-module
.S.....S......S.........SSSS.........................................................................................................................................................................................................S.................SS.........S..........S...................
Total tests: 321, Failures: 0, Skipped: 23, Time: 1.817 seconds

yogi [info] yuitest tests complete
Starting Grover on 8 files with PhantomJS@1.9.0
Running 15 concurrent tests at a time.
✔ [YUI: Array]: Passed: 20 Failed: 0 Total: 20 (ignored 0) (0.201 seconds)
✔ [YUI: Object]: Passed: 17 Failed: 0 Total: 17 (ignored 0) (0.171 seconds)
✔ [testSuite_yui_3_5_0_1_1413876295435_53]: Passed: 22 Failed: 0 Total: 22 (ignored 0) (0.719 seconds)
✔ [YUI: User Agent]: Passed: 205 Failed: 0 Total: 207 (ignored 2) (2.334 seconds)
✔ [YUI: Full]: Passed: 53 Failed: 0 Total: 54 (ignored 1) (8.841 seconds)
✔ [YUI: Static]: Passed: 53 Failed: 0 Total: 54 (ignored 1) (8.802 seconds)
✔ [YUI: Fetch]: Passed: 53 Failed: 0 Total: 54 (ignored 1) (8.865 seconds)
✔ [YUI: All]: Passed: 316 Failed: 0 Total: 320 (ignored 4) (12.015 seconds)
----------------------------------------------------------------
✔ [Total]: Passed: 739 Failed: 0 Total: 748 (ignored 9) (41.948 seconds)
[Grover Execution Timer] 12.84 seconds
yogi [info] grover tests complete
```

Another thing I want to consult you, is there a way I can deploy the YUI directly to the liferay portal so that I can the impact of code changing?

I realized I need to delete the old version of aui.zip in the third-party folder of the portal-web. But where is the new version could come from apart from using the Patcher portal?

I did copy some files directly into the zip but it failed to work and I think it is awkward.

Thanks
John.