gentoo-perl/g-cpan — pull request #16 by gagern (2014-10-21 09:52:14+00:00)
Title: Turn \t into space.

*See also [Gentoo bug 526192](https://bugs.gentoo.org/show_bug.cgi?id=526192).*

Even after fixing the warnings from [bug 526188](https://bugs.gentoo.org/show_bug.cgi?id=526188) a.k.a. issue #6, g-cpan reports

* DEFINED OVERLAYS DON'T EXIST!

This is because the `PORTDIR_OVERLAY` variable in my make.conf contains tabs. `set` reports these as `$'…\t…'` and `strip_env` from `Gentoo::Portage` (as installed by g-cpan) removes the `\` but keeps the `t`. So I guess we should add `\\t` to the `\\n` handling in there.

----

*Note* that this whole `strip_env` function looks somewhat suspicious to me. As far as I can tell, it is only ever called with the *value* of the environment variable as an argument, never with its *name*. In that case, looking for `$ENV{$key}` might be one redirection too many, and cause surprising results. And modifying the key after we tweaked the environment setting for the unmodified key looks even stranger. Can we simply drop the whole first case of that if…else construct, and execute the second case unconditionally? Perhaps renaming `$key` to `$val` in the process? Or am I missing some point here?