onaio/zebra — pull request #849 by prabhasp (2014-10-20 12:04:09+00:00)
Title: [DO NOT MERGE] 649 more dataview tests

@pld, I started testing the table component with work on this branch. (I can test that we render [N rows](https://github.com/onaio/zebra/compare/649_more_dataview_tests?expand=1#diff-7bc673a19c08191a36bdab58802778e0R47) on the table... isn't that cool!?). Anyways, ran into a small snag. Using the polyfill that we were using, I was getting an error [1]. Googling led me to a thread [2] and a link to [Facebook/React's polyfill](https://github.com/facebook/react/blob/master/src/test/phantomjs-shims.js). This branch includes that polyfill, but that breaks a test in [projects-test/modal-back](https://github.com/onaio/zebra/blob/master/test/cljs/ona/project_test.cljs#L56-L57) [3]. I tried a whole bunch of polyfills for `.bind`, and almost all break that `modal-back` test. Is it possible to change that test? IDEALLY, if you could fix `modal-back` with the new polyfill in this branch, I would be the happiest.
Possible?

By the way, another one (which has the same behavior as FB's polyfill, is [es5-shim](https://github.com/es-shims/es5-shim), which may be worth considering as well).

[2] -
```
FAIL in (ona.project-test/modal-back) (:)
expected: (= (project/modal-back :a :b :c) nil)
actual: (not (= # nil))
```
[3] - https://github.com/facebook/react/issues/945
[1] -
```
TypeError: instanceof called on an object with an invalid prototype property.

resources/public/extra/polyfill.js:12
target/main-test.js:18
...
target/main-test.js:56031 in render
target/main-test.js:61421 in rootf
target/main-test.js:61512 in root
target/main-test.js:65467 in table_and_container
target/main-test.js:65473
```