saltstack-formulas/nginx-formula — pull request #56 by rfairburn (2014-10-20 09:14:08+00:00)
Title: Fix support for os_family RedHat

This set of changes should make the base formula (did not touch the ng formula as I needed something working on 2014.1.x) work with the os_family RedHat. Currently I have no issues if I use the upstart version of the formula whatsoever. However, when utilizing the sysvinit version, I am running into locking in the nginx loggers and the nginx sysvinit services. I would guess it is related to some subprocess interaction similar to https://github.com/saltstack/salt/issues/14957, but maybe someone else has an idea.

I still wanted to share the PR because, as I said, it at least works well with upstart with these changes in place, and even sysvinit is in better shape for the RedHat family than before. It may be worth noting that the init scripts might be able to be changed to support lsb style init functions, but redhat-lsb would become a package dependency, and it can be extra bloat people may not want.

If there are any changes you would like to see before accepting this pull, please let me know, and I would be happy to assist. I am also generally on IRC in #salt as SheetiS if you would like to discuss real-time.