test-kitchen/test-kitchen — pull request #527 by chrishenry (2014-10-20 23:46:51+00:00)
Title: Auth failure retry

Hello,

We've recently started running into the situation described [here](https://github.com/test-kitchen/test-kitchen/issues/449#issuecomment-44918219), where `test-kitchen` will fail an `AuthenticationFailed` error. As @juliandunn described, we were experiencing an authentication failure that happened just after SSH was available caused by the `authorized_keys` file not being updated. Simply waiting a few moments fixed the issue. So I've added the `AuthenticationFailed` error to the list of exceptions that will trigger a retry.

One question regarding the tests. As I was running them, I noticed [this test](https://github.com/test-kitchen/test-kitchen/blob/master/spec/kitchen/ssh_spec.rb#L418) in particular would fail with the following;

```
Finished in 4.011749s, 309.0921 runs/s, 479.3421 assertions/s.

1) Failure:
Kitchen::SSH::#upload_path!#test_0002_logs upload progress to debug [/Users/chrishenry/Code/behanceops/test-kitchen/spec/kitchen/ssh_spec.rb:418]:
Expected /^D, .* : Uploaded\ \/tmp\/local20141020\-2409\-1197n8i\/alpha\ \(15\ bytes\)$/ to match "D, [2014-10-20T19:30:13.779223 #2409] DEBUG -- : [SSH] opening connection to me@foo:22<{}>\nD, [2014-10-20T19:30:13.779994 #2409] DEBUG -- : Uploaded /var/folders/90/13_pxfhx0plfyzg6t_g480g00000gq/T/local20141020-2409-1197n8i/alpha (15 bytes)\nD, [2014-10-20T19:30:13.780465 #2409] DEBUG -- : Uploaded /var/folders/90/13_pxfhx0plfyzg6t_g480g00000gq/T/local20141020-2409-1197n8i/subdir/beta (14 bytes)\nD, [2014-10-20T19:30:13.780841 #2409] DEBUG -- : Uploaded /var/folders/90/13_pxfhx0plfyzg6t_g480g00000gq/T/local20141020-2409-1197n8i/zulu (14 bytes)\n".
```

Am I not configured correctly? Or is something else at play there?