joeferner/node-oracle — pull request #223 by ericwaldheim (2014-10-20 21:11:37+00:00)
Title: Compile on node 11.14 using nan v1.3.0

Hello,
I failed to find any work done on a node 0.11.14 port so I modified the source to compile on node 0.11.14 by using nan v1.3.0.
I built and ran regression tests on both node 0.11.14 and 0.10.25.
(The database setup in test/outparams.js appears to be missing setup for procedure "procDateTimeOutParam".)

The modifications were straightforward except for:

1) I replaced String::NewSymbol with NanNew. Nan docs indicate this is correct but I'd like to confirm.
2) reader.cpp line 124 baton->callback.Clear(); I could not find the Nan replacement for the Clear call. I just blithely commented it out. What is the correct answer?
3) statement.cpp line 94 baton->callback.Clear(); Same issue as number 2).

And I suppose question one is, how do you feel about nan?

Thank you,
Eric