piwik/piwik — pull request #6480 by mgriego (2014-10-20 19:47:54+00:00)
Title: Suppress cron errors while performing file cleanup

When performing simultaneous cron core:archive runs for large instances, there is a race condition during the file cleanup phase when one process sees the files of another process just before the other process deletes those files, causing the filemtime() call to fail since the file no longer exists. Also, since the return value from filemtime() is not checked for failure (=== FALSE), it tries to unlink() the file on failure, which also fails. At the least, this is causing unnecessary emailings from the cron process. The failure of filemtime() is harmless, though unlinking on that failure *may* not be. The filemtime() failure can be safely ignored since this function's only purpose is to clean up old files, and the failure just means the file no longer exists.