MushroomObserver/mushroom-observer — pull request #13 by mo-nathan (2014-10-17 13:47:42+00:00)
Title: Rails 3.2 upgrade

Fixed account_mailer tests which were broken due to subtle change the way ActionMailer::Base.mail works. As a result I ran rubocop on account_mailer.rb which ended up providing an opportunity to refactor account_mailer.rb. It’s way better now (IMO), but it’s not quite where it really should be. The biggest change is that I broke out each email into its own class and used AccountMailer as the base class. I thought about combining the emails into various groups, but ultimately I decided they were all artificial and all the shared code was in AccountMailer anyway. From the rubocop perspective it when from 215 violations to 0. The creation of the subclasses caused the views to move. Ultimately I'd like all the subclass to follow the model in app/model/mailers/name_change_email.rb which just takes the QueuedEmail rather than unpacking essentially the same info and then sending it on to the view. The views have a huge amount of logic in them that should really move into the Mailer classes, but those changes are for another day.

It appears that between 3.1 and 3.2 they reversed the decision to use ‘?id=#’ by default so a bunch of tests had to change back to looking for ‘/#’. There was also a bug they fixed in CSS expression selectors that we were relying on.

They also made the CookieJar a real object rather than just a list of Cookies so comparing it to [] had to be changed to cookies.count.

Finally I switch from the ruby-rtf vendor plugin to the rtf gem.