gocardless/statesman — pull request #94 by netikular (2014-10-15 22:13:25+00:00)
Title: Resolving deprecation warnings when using implicit joins

Hi, I was getting a warning on recent versions of rails.

DEPRECATION WARNING: It looks like you are eager loading table(s) (one of: requests, transition1, transition2, floor) that are referenced in a string SQL snippet.

I looked into the code and noticed that the in_state and the not_in_state scopes do not reference the transition table. I've added the reference and the include to query and that resolved the deprecation warning I was getting. I also submitted issue #93 to track a conversation about this.

Since this is not coming up in the specs when run on just the project itself, I am not sure how to add a spec for this.