rotty3000/liferay-portal — pull request #637 by lipusz (2014-10-14 14:30:47+00:00)
Title: [TECHNICAL-SUPPORT | Oct 18] LPS-50830 Can not get String array from Expandovalue with "Group of Text Values" in case of DM

https://issues.liferay.com/browse/LPS-50830

Hi Ray,

This exactly the same issue what you fixed in https://issues.liferay.com/browse/LPS-44195, though, it's still reproducible since method "getExpandoValue" is overloaded:
1-
````java
@Override
public Serializable getExpandoValue(
PortletRequest portletRequest, String name, int type,
String displayType)
throws PortalException, SystemException {...}
````
2-
````java
@Override
public Serializable getExpandoValue(
UploadPortletRequest uploadPortletRequest, String name, int type,
String displayType)
throws PortalException, SystemException {...}
````
LPS-44195 fixed the issue in the 1st method only.

In order to reduce code duplication I changed the signatures of methods:
````diff
-Map getExpandoBridgeAttributes(ExpandoBridge expandoBridge, UploadPortletRequest uploadPortletRequest)
+Map getExpandoBridgeAttributes(ExpandoBridge expandoBridge, HttpServletRequest request)
````
and

````diff
-Serializable getExpandoValue(UploadPortletRequest uploadPortletRequest, String name, int type, String displayType)
+Serializable getExpandoValue(HttpServletRequest request, String name, int type, String displayType)
````

and changed the others that receive a PortletRequest to call the ones above. This shouldn't break anything as UploadPortletRequest extends HttpServletRequest.

Let me know if you don't like it.

Thanks,
Tibor