xbmc/xbmc — pull request #5501 by Montellese (2014-10-13 22:36:52+00:00)
Title: CGUIDialogSettingsBase: fix default control overriding

This fixes the default control definition in windows/dialogs based on CGUIDialogSettingsBase. Without this the default control is always set to either the control ID of the category button group or the settings control group independent of what is set in the skin XML. This works fine in windows/dialogs that only contain categories and settings but fails in other dialogs like CGUIDialogContentSettings where there are also other controls. Therefore right now the "Change scraper" dialog in the music library is completely broken because focus is forced onto the settings control group which is empty and therefore nothing is focused and it becomes impossible to move to any other control (this is a general problem with empty lists in XBMC).

This changes the behaviour to only manually set the default control if it is either not set or e.g. set to the category button control and there are no categories available.

@MilhouseVH: Thanks for reporting this and please let me know if it fixes the problem for you.