cli6cli6/Chao_GA_Projects — pull request #6 by ZackDinerstein (2014-10-13 20:43:04+00:00)
Title: Assignment #6 - Rock Paper Scissors - Feedback

Hey Chao, great job! The site looks beautiful and functions perfectly. Good work.

The one major area I see that I think you can improve on is formatting. Your HTML, CSS, and JavaScript code is well put together (good choice of tags and css rules). It's formatting (indentation) is a bit sloppy. This might seem like a small point, but it's very important when writing long programs, (especially long JS program).

For HTML:

1) Don't indent your ,

, or

tags.
2) Make sure all of your opening tags have closing tags
3) class and id names should be hyphenated "results-two"

For CSS:

1) One space btw CSS rules
2) One space btw CSS tags and first bracket ( "body {" instead of "body{" )
3) All rules inside of an element should be indented one tab. For example:

#ribbon:before {
left:-1.35em;
border-right-width: .75em;
border-left-color:transparent;
}

4) Closing brackets should be at the same indentation level as the first letter of your style rule.

For JS:
1) Indent every line that's contained within a function or loop. For example:

function evaluateChoices (playerChoice, cpuChoice) {
console.log(playerChoice);
console.log(playerChoice);
}

2) Make sure your closing brackets line up with the first letter of the function or loop they're attached to.

Once your formatting's down, it'll be much easier for you to build amazing, complex functions.