alphagov/publisher — pull request #266 by fofr (2014-10-10 16:59:06+00:00)
Title: Remove highlighted editions from publications lists

When using the "user search" feature the results include a view link. This link takes you to a publication list with the selected edition highlighted, within the context of other editions. Examples:
https://publisher.preview.alphagov.co.uk/user_search?user_filter=BQ06DJyvxdIAJ3Xb-adtmA&string_filter=
https://publisher.preview.alphagov.co.uk/?with=5436bb1740f0b61389000001

Analytics shows this feature was used only 4 times in the last six months, and with questionable usefulness. When asked about the overall user search function, most used the filters on the left of the main publication list. Analytics suggests the same.

* Simplify templates by removing highlights
* Update user search results to link to the edition directly, rather than circuitously through the main publication table
* Remove logic and tests which altered the publication list when a `with` param was present

(Mostly undoing this commit: https://github.com/alphagov/publisher/commit/34a6e4a43a45f04ace9e2fb59bce266f4d3574bb)

cc @fatbusinessman