tgstation/-tg-station — pull request #5171 by phil235 (2014-10-10 15:26:14+00:00)
Title: A lot of secbot/ed-209 fixes.

* FIX: the taser that ed209 drops on death looks full but is empty
* FIX: issue #4487 (lasersound)
* Fix: you can repair bot with weldingtool off.(Adding a warning msg).
* FIX: medbot fleeing one step when repairing it with weldingtool or using holosword.(it now no longer moves during this)
* Fix: attacking silicon w/ holosword gives spark.(it shouldn't)
* FIX: attacking bot w/ holosword is considered an assault.(it shouldn't)
* FIX: bots produce spark when damaged via attakby, similar to borgs.
* FIX: attacking ED209 with weldingtool on harm doesn't triggers the bot response to that assault.(it does now)
* Bots will now produce sparks when hit by projectile w/ damage>0. (to have some feedback b/c there's no msg otherwise)
* FIX: ED209 doesn't try to tase monkey despite wanting to arrest.
* FIX: LaserTAG ED209 points at monkey despite not shooting/hunting them.
* We will no longer check projectiletype and sound each time an ED209 fires. (Now only checks when using New() or emagging/hacking/emp'ing) (also simplifying code)
* FIX: cannot access behavior mode to toggle patrol on lasertag ED209 (despite the fact that it should be able to patrol)
* FIX: ED209 tases cuffed target that are standing when in arrest mode.
* FIX: ED209 can stun through a closet! And, it can cuff through windows and closet.
* FIX: the handcuffing problem. ( issue #2025 )
* FIX: no message when trying to screwdriver panel of bots open but it's locked.
* FIX: added one audible message instead of for+show
* 'detain' mode now means the target is repeatedly stunned, preventing escape. (issue #3900)
* FIX: After finishing summon order, bot goes patrolling even if he doesn't have "auto_patrol" on.
* FIX: ED209 cannot be summoned because they don't appear on the list of secbots of the PDA securitron interlink cartridge.(they are now added to the list)
* FIX: autocustom names for lasertag ed209s doesn't work (if you don't give them a custom name, it gives them a custom one from a list)

Also:
* Removing maxstuns var in process() proc of both ED and beepsky. It doesn't do shit.
* Lasertag ED no longer calls look_for_perp(), the loss in reaction speed is minimal and it no longer calls for infraction.
* Adding myself as game master in admin list.