genome/genome — pull request #89 by davidlmorton (2014-10-09 12:11:05+00:00)
Title: Override get_or_create not create

Overriding create is problematic since create will return undef if it
finds an existing SR (and this is done before locking). When undef is
returned, the rest of our overridden create function is broken. Since we
need a guarantee that we will either get or create a $self, we need to
override get_or create instead.

One unappealing side-effect of this is that calling 'create' on our
class now doesn't actually fully create the software-result, only the
database entry for it. So long as nobody expects that the work will be
done when calling 'create' directly, this is ok, but it seems
non-intuitive.