cms-sw/cmssw — pull request #5671 by mark-grimes (2014-10-03 11:55:10+00:00)
Title: Fix failure during merge when histogram limits are invalid

This should stop the relval failures for HGCal. The problem was that validation plots were being booked with equal minimum and maximum limits which causes root to fail when adding them together during merging. This adds a check during the merging to ignore histograms where the min is not less than the max. **This does not fix the underlying problem**, it merely stops it failing the whole merge.

The underlying problem is for the following plots:

HcalHitsV/SimHitsValidationHcal/HcalHitEtaHE0-z
HcalHitsV/SimHitsValidationHcal/HcalHitEtaHE2+z
HcalHitsV/SimHitsValidationHcal/HcalHitEtaHE2-z
HcalHitsV/SimHitsValidationHcal/HcalHitTimeAEtaHE0-z
HcalHitsV/SimHitsValidationHcal/HcalHitTimeAEtaHE2+z
HcalHitsV/SimHitsValidationHcal/HcalHitTimeAEtaHE2-z
HcalHitsV/SimHitsValidationHcal/HcalHitE100HE0-z
HcalHitsV/SimHitsValidationHcal/HcalHitE100HE2+z
HcalHitsV/SimHitsValidationHcal/HcalHitE100HE2-z
HcalHitsV/SimHitsValidationHcal/HcalHitE250HE0-z
HcalHitsV/SimHitsValidationHcal/HcalHitE250HE2+z
HcalHitsV/SimHitsValidationHcal/HcalHitE250HE2-z
HcalHitsV/SimHitsValidationHcal/HcalHitE25HE0-z
HcalHitsV/SimHitsValidationHcal/HcalHitE25HE2+z
HcalHitsV/SimHitsValidationHcal/HcalHitE25HE2-z
HcalHitsV/SimHitsValidationHcal/HcalHitE50HE0-z
HcalHitsV/SimHitsValidationHcal/HcalHitE50HE2+z
HcalHitsV/SimHitsValidationHcal/HcalHitE50HE2-z

It appears that the limits are set dynamically in [SimHitsValidationHcal::getLimits](https://github.com/cms-sw/cmssw/blob/CMSSW_6_2_X_SLHC/Validation/HcalHits/src/SimHitsValidationHcal.cc#L302) and this is failing for HGCal and returning equal numbers.

@vandreev11, @pfs, @boudoul, @davidlange6 (also @lgray since you were on some thread about it).