DarkstarProject/darkstar — pull request #514 by TeoTwawki (2014-10-03 02:33:26+00:00)
Title: more abysystuffs

Implemented quest "The Truth Beckons", and the start of "Dawn of Death"
Added script for the maw in Konschtat Highlands.
Repaired busted zone.lua in Port Jeuno.
Added a default position to every Abyssea zone so we'd stop @zone'ing into empty space during testing.

Looking over scripts offered by @LegionXI
Some of it can be reworked to not rely on NPC IDs as a trigger condition since updates can break those and will fit with what I had already started working on for treasure boxes outside abyssea (roughly same system, abyssea just has more box types to deal with).

Regarding the future of magian trials:
I really want to avoid having to add a check in on death for every mob in every zone for some things though, so I will need to work out how to handle checking the trial objectives and if the mobs meet those in core to avoid that. I'm also thinking of moving the info for said trials into a db table instead of those huge lua tables I started on. Any feedback about how you think any of that should go are appreciated.

...Could do the same to those big FoV/GoV info tables eventually. GoV began as a hack to FoV, and I had to split them up because the lua file was to large, but a single db table could hold all the regime info for FoV GoV Hunts and Dominion OPs. I think I'd still need to keep the onDeath checks for those however, because they aren't neatly divided into mob families and weather conditions like magian trials are.