NerdNu/KitchenSink — pull request #33 by totemo (2014-10-01 08:57:23+00:00)
Title: Now with added sarcasm!!1!

My CH /s (sarcasm) command was inadvertently tested with KitchenSink disabled. KitchenSink intercepts the player chat created by /s and strips formatting from it. This pull reinstates the italics (only).

Commit Message:

The chat spam filter in onPlayerChat() removes all colour codes from players'
chat messages. (This is why we can't have nice things.) Unfortunately, this
strips italics from chat messages created using /s (sarcasm). This patch
detects italics at the start of a chat message and adds it back in after the
message is stripped of formatting.

An alternative solution would have been to change the /s CH script to broadcast
the message instead, bypassing the onPlayerChat() event. However, I expect that
would have had the undesirable side-effect of allowing /s to bypass /ignore,
where that is enabled.