ManageIQ/manageiq — pull request #746 by Fryguy (2014-09-30 19:47:54+00:00)
Title: Fix specs that reference the wrong fields in ops_controller/common

@dclarizio Please review...I think this fixes the sporadic failures we are seeing, notably in #745 and #725 .

The tests in question are supposed to be testing what happens when one checks a "storage" checkbox in the UI and how it is expected to affect `@edit`. However, it seems like there was a few typos and it is checking the wrong thing. The first spec checks the `__storage` box, but then it verifies the `:hosts` key in `@edit`, which is wrong. The second spec is supposed to uncheck the `__storage` box, but instead unchecks a `__host` box...in addition it verifies against the `:hosts` key in `@edit` instead of `:storage`, which is wrong.

I believe the test is sporadically failing because it is comparing storage ids to host ids, and depending on luck and/or test ordering those id numbers will happen to line up. (Thanks @blomquisg for the insight on that last point)

cc @kbrock @jrafanie