kestasjk/webDiplomacy — pull request #41 by TimothyJones (2014-10-01 04:20:14+00:00)
Title: Fix for disband ordering

This fixes a bug with disband ordering on NMR (DATC 6.J.7: Fleets should disband before armies). Previously, the implementation disbanded armies before fleets, but it should be the other way round (as [per page 18 of the rulebook](http://www.wizards.com/avalonhill/rules/diplomacy.pdf)).

* The bug was recently [reported via the forums](http://webdiplomacy.net/forum.php?threadID=1186091#1186091)
* And confirmed in Russia's Autumn 1905 disbands in [this game](http://webdiplomacy.net/board.php?gameID=147463)

To test, I set up a game with Russian units in: F Liv, A St P, A Ukr, F Bla. Russia had one disband. Before the patch, A Ukr was the disband. After winding the phase back, applying the patch, and rebuilding the destroy index via the admin panel, F Bla was correctly disbanded.

At some point, we should implement section 6 of the DATC, but this patch will fix this bug for now.