xtuple/qt-client — pull request #505 by krauseo (2014-09-30 02:59:02+00:00)
Title: Issue #24588 - set reservations metrics only if reservations enabled

The problem is that when Enable Reservations is unchecked, the code behind the QGroupBox does not uncheck Require Reservations and Location Reservations. The metrics for those still get set to True because the current code doesn't also check if Enable Reservations is checked. The IssueLineToShipping and IssueAllToShipping functions only check to see if Require Reservations is true, not to see if Enable Reservations is true. I think it's better to change configureSO to properly set the metrics under Enable Reservations.

I have spent six hours trying to figure out how to eliminate from this PR the old SalesOrderItem commit that was merged earlier today. I can't figure it out, so I'm putting this out there so you can see the change that's needed in configureSO, and you'll have to figure out how to get that stuff out (if it even needs to be taken out since it's already been merged) and still give me my haxtuple point. I enjoy the haxtuple competition, but you have to make it easier for people to submit changes, because I only have so much time I can spend doing free bug fixing for xTuple. It should have taken me two minutes to submit this change, not an entire evening. Git is just not an intuitive enough tool for someone who does not work with it every day and who does not have time to learn all its oddities. The answer isn't just giving people Git command line commands to run, it's giving people a cleaner submission front-end to Git. I left the command line world about 15 years ago and don't wish to go back. I think I've shown over the past month that I can provide a lot of value to the community even after haxtuple ends, but my doing so is going to require that it be easier for me.