Yelp/gh-kit — pull request #15 by matthewkyelp (2014-09-29 22:56:27+00:00)
Title: MatthewK-Bugfix: Fixing links in talk not opening correctly.

This change fixes a bug where talk links did not open correctly. The issue was that gh_deriveWithQuery was incorrectly encoding some URLs twice. This was due to fixes for a previous bug where some URLs were passing through gh_deriveWithQuery without being encoded at all. The original/underlying issue was that gh_deriveWithQuery was treating the call to path on NSURL as if it returned an escaped URL path. This is not the case as path returns an unescaped URL path. I now escape the result of the path call. gh_deriveWithQuery now works for this issue as well as the original issue.

I also added an additional test case that creates and tests a URL similar to what comes from talk links. (Redirected URLS that have been escaped).

Related asana:

https://app.asana.com/0/16390146192030/16759394097354