CleverRaven/Cataclysm-DDA — pull request #9246 by jcd000 (2014-09-25 21:23:44+00:00)
Title: Hoarder trait remake

Now its a 1 pt. cost trait that can give uo to +15 morale for a late-game survivor loaded to capacity,
but will also take up to -15 morale for survivors loaded with less than 50% of their max capacity.
The bonus/penalty is scalar.

Exact logic&formula:

hoarders get a bonus when carrying stuff, regardless of max capacity.
this is small, and counted thus:
bonus = (weight carried*2 + volume carried)/60

they also get a bonus if they are loaded with volume taking more than 50% of their max volume.
this bonus is pretty small, until the player goes to 90% capacity and beyond. formula
bonus = ((carried volume / max volume)^6)*10
this means that this bonus is capped at +10

if the survivor is loaded to less than 50% of his max capacity, he gets a penalty:
the penalty is linear (-1 morale per 1% under 50) and not capped at this point. formula:
penalty = 50 - (carried volume / max volume)*100

so to calculate the final effect, we add all the morale modifiers.
total bonus is capped at +15 and total penalty at -15
===========

the trait costs 1pt since i expect it to give more than morale than it will take as it is.