mozilla/treeherder-ui — pull request #206 by tojonmz (2014-09-25 17:03:44+00:00)
Title: Bug 1068532 - Ignore keyboard shortcuts if modifiers used

This fixes Bugzilla bug [1068532](https://bugzilla.mozilla.org/show_bug.cgi?id=1068532).

This allows users to invoke various browser side keyboard shortcuts, and not have treeherder interpret them as platform shortcuts.

For example:
* (p) - previous failure, (**Ctrl** +p) - print
* (j) - next failure, (**Shft+Ctrl** +j) - console
* (p) - previous failure, (**Shift+Ctrl** +p) - new private browsing window

...and so forth with each of the variations on Firefox and Chrome.

Originally I was anticipating needing to create special tests for each set of treeherder keyboard shortcuts, but it seems we get the desired behavior for all the shortcuts I've looked at, if we test for the key modifier at the top of the entire block. I've tested pretty extensively on Firefox and Chrome and both seem to be behaving fine.

I've tested:
* print
* history sidebar
* bookmark sidebar
* console
* new window
* new private browsing window

Tested on Windows:
FF Release **32.0.3**
Chrome Latest Release **37.0.2062.124 m**

Adding @camd and @maurodoglio for review.