OpenRA/OpenRA — pull request #6514 by reaperrr (2014-09-20 12:36:28+00:00)
Title: Moves LimitedAmmo and Reloads functionality to Armament

Still WIP, but I need some feedback/help.

Some notes as of 2014-09-20 14:22 CMT+1:
- ```Rearm``` activity seems to be broken (the main problem at the moment), helicopters don't refill depleted ammo
- HackyAI needs a limited ammo check, but I couldn't get my head around on how to implement it in that particular case
- I have no idea whether my changes to ```AirStates``` and ```FlyAttack```/```HeliAttack``` really work as intended
- It would probably make sense to get rid of ```Reloads``` entirely as well and add a boolean to ```Armament``` instead, but the LimitedAmmo checks in various other traits & activities caused enough headaches as it is, so I'll leave this for later
- Duplicated most stuff from ```LimitedAmmo``` to ```Minelayer```, I don't think we want an ```Armament```-dependence here
- Minelayer reloading seems to work without ```Rearm``` activity, so the related stuff in ```Rearm``` is probably redundant
- Haven't removed ```LimitedAmmo``` just yet