busbud/coding-challenge-frontend-a — pull request #4 by nebez (2014-09-21 05:21:10+00:00)
Title: Front-end coding challenge

Hey!

Just a couple of notes on the pull request:
* I purposely left the compiled css in repo. I figured you shouldn't have to install all of my dependencies just to look at it (they're all in devDependencies of package.json if you'd like to use the gulp script yourself, though)
* On a similar note, I'll be hosting a copy of the built app here for the next few days for your convenience: http://173.246.10.10:8181/#en. The only issue is it's not part of the Typekit whitelist so you won't get the proxima-nova font face.
* I had to create a proxy for accessing the suggestion endpoint. I didn't want to, it feels like unnecessary work, but unfortunately you can't set custom headers via JSONP (it's not an Ajax call) and browser restrictions don't let us use regular Ajax requests to get the JSON. It took me a while to realize that I couldn't append custom headers to a JSONP request (whoops). Maybe this should be noted in the README.me to go along with the new addition of the guest token endpoint.
* I opted out of using a view rendering engine for the app. The content is all static and nothing changes (except for the /lang and /search directories, but they return json), so it didn't really make sense to me to use one. The convenience of using a templating engine like Jade might've been more emphasized in a different scenario though, but the pages syntax was small and verbose enough to just use HTML.
* I didn't know how to style the page exactly. The images referenced in the default index.jade stylesheet no longer existed, and the screenshot in the README.md didn't really match the template spat out by index.jade. I went with my gut feeling and tried to mimic the screenshot (and the actual busbud.com website) instead. I hope this is okay, since it doesn't match the default index.jade view.
* Lastly, the image included in the pull request (used in the background), bg.png, has a CC0 license so it shouldn't be an issue that I'm including it. I've included the reference at the bottom of notes.md.

Thanks again for allowing me to complete the challenge when I had more free time. I had a lot of fun implementing this.
If there's anything I'm forgetting, or you have any suggestions for me, let me know.

Thanks!