jbohren-forks/catkin_tools — pull request #1 by wjwwood (2014-09-17 23:15:31+00:00)
Title: Metadata file fixup

Just some things I found while reviewing the code (yes I am still working on it... just ever so slowly).

Honestly most of these things should be caught by your editor, I would suggest upgrading your tools to have better checking of static code.

- Trailing whitespace: be4b11b
- These are just nice to have:
- unused imports: 6ed95b8
- unused variables: 9c8bbd9
- But this one would case run time errors!!: 14e68b9

The rest were caught by running the doc generation locally, there were a handful of sphinx warnings.

I'm play testing (for lack of a better phrase) the tools. I think they are really good, and we can probably address small behavior and feature things after merging the main pull request. My final task is to review the changes to the docs. Then we should be good to merge this guy.

Thanks again for this MAJOR contribution. I'm sure a lot the community will appreciate it!