sequelpro/sequelpro — pull request #1987 by uxp (2014-09-17 17:10:05+00:00)
Title: Disable smart quotes and em dash text replacement

When the systemwide "Use smart quotes and dashes" option is enabled in Mavericks (System Preferences > Keyboard > Text), the SQL Query editor tries to replace single and double quote characters (', ") with their typographical correct equivalents (‘, ’ and “, ”) as well as a double dash (--) with an Em Dash (—). This may be a wanted setting, but as these replaced characters are not valid string and comment characters, respectively, it breaks the validity of the typed SQL code.

I've debated whether or not this should be a toggle-able option in the application's editor preferences, but I cannot see a reason that one would ever want to have these characters replaced within SQL. If one did want to enter in the typographical quotes or an em dash as characters within a varchar string (for example), then they could simply use the correct alt-keys (alt+[, alt+], shift+alt+[, and shift+alt+] and alt+-) to insert these characters. In relation to issue #1165, the triple-period ellipses (...) nor the single-character ellipses (…) are valid SQL syntactic elements by themselves, so I see this as a valid reason for overriding the system defaults for these characters, whereas it didn't make sense to override the defaults for characters that don't contribute to SQL syntax.