joomla/joomla-cms — pull request #4284 by betweenbrain (2014-09-16 13:30:35+00:00)
Title: Restore support for rendering custom fieldsets when using JLayout 'joomla.edit.params'

## Background
With the implementation of using JLayout to render parameters (https://github.com/joomla/joomla-cms/pull/2162) support for rendering custom named fieldsets ceased to be supported. This is a documented feature since at least Joomla 2.5 http://docs.joomla.org/Adding_custom_fields_to_the_article_component and is also documented to be suported in 3.1 at http://docs.joomla.org/Adding_custom_fields_to_core_components_using_a_plugin. In fact, the current core user profile plugin would break if JLayout 'joomla.edit.params' was implemented for com_users.user due to the plugin using custom named fieldsets (https://github.com/joomla/joomla-cms/blob/staging/plugins/user/profile/profiles/profile.xml#L3-L4) and the current implementation of JLayout 'joomla.edit.params' being effectively hardcoded to only render fieldsets named `params` and `attribs` (https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L15-L18).

## Changes
This PR changes the behavior of JLayout 'joomla.edit.params' to render all fieldsets of the form, except those designated with the `ignore_fieldsets` property.

Affected by this PR are the following backend edit views:
* com_categories.category
* com_contact.contact
* com_content.article
* com_finder.filter
* com_menus.item
* com_modules.module
* com_newsfeeds.newsfeed
* com_plugins.plugin
* com_tags.tag
* com_templates.style
* com_weblinks.weblink

## Backwards Compatibility
This PR should be 100% backwards compatible while restoring this functionality.

## Testing
Apply the patch associated with this PR and review the above views to ensure that all of the currently rendered fieldsets (as tabs in Isis) remain to be rendered. Then, install and plugin that uses a custom named fieldset and ensure that it is rendered at all of the above views as described in Joomla's documentation.

A test plugin can be downloaded from https://github.com/betweenbrain/Joomla-Custom-Field-Plugin-Example/archive/test.zip