ManageIQ/manageiq — pull request #608 by jrafanie (2014-09-15 16:00:45+00:00)
Title: VMWareMetadata is not called anywhere.

It looks like it was last modified for conversion to binary_struct here: 00a7dd423c738574008fe1895a5e19f27e32ac98

And the last substantial change was in 2009 here:
05d517b984ea1ecd89793063ece88ebd0be97927

The test contains invalid ruby 1.9 syntax, see below, and also contains binary string literals that may cause issues in ruby 2.0+.

```
lib/metadata/VMWare/test/vmdk.rb:114:13: E: unexpected token tCOLON
when 7: return "NTFS"
^
lib/metadata/VMWare/test/vmdk.rb:115:5: E: unexpected token kWHEN
when 12: return "FAT32"
^^^^
lib/metadata/VMWare/test/vmdk.rb:116:5: E: unexpected token kWHEN
when 131: return "ext2"
^^^^
lib/metadata/VMWare/test/vmdk.rb:119:1: E: unexpected token kEND
end
^^^
lib/metadata/VMWare/test/vmdk.rb:190:18: E: unexpected token tCOLON
when "SPARSE": parseDiskSparse(disk)
^
lib/metadata/VMWare/test/vmdk.rb:191:5: W: else without rescue is useless
else raise "Unrecognized Disk Type - #{disk["type"]}"
^^^^
lib/metadata/VMWare/test/vmdk.rb:193:1: E: unexpected token kEND
end
^^^
```