janestreet/core_bench — pull request #5 by planar (2014-09-15 18:28:35+00:00)
Title: fix invalid printf format

There is a format string that is "invalid" in the core_bench sources.

In general, invalid formats are nonsensical format strings that were accepted in OCaml 4.01.0 and earlier, but whose semantics is unspecified. They are still accepted by the new Printf implementation of OCaml 4.02.0 but in some cases with different semantics, and they will be statically rejected by OCaml 4.03.0.

You can check for them in OCaml 4.02.0 with the flag -strict-formats.

In the case of core_bench, I think the behavior has not changed between 4.01.0 and 4.02.0. The only invalid format is "%0.2f". This is considered invalid beause it specifies a padding character (with the flag 0), but no minimum field width (no number before the dot) so there will never be padding. Even though the behaviour has not changed, you should take the opportunity to review the code and fix the format. The patch changes it to "%.2f", which keeps the behaviour unchanged, but that might not be the intended behaviour.