browse-kill-ring/browse-kill-ring — pull request #45 by T-J-Teru (2014-09-12 21:50:06+00:00)
Title: Prevent ...-edit-finish being using in non edit buffer.

The change description:

> Calling `browse-kill-ring-edit-finish` in a buffer that is not a browse-kill-ring edit buffer will now give an error, this relies on `browse-kill-ring-edit-target` always being set in a browse-kill-ring edit buffer, which should always be true; `browse-kill-ring-edit` will throw an error if `browse-kill-ring-edit-target` can't be set.

This change was mentioned in a comment on PR #39, at the time I thought that this code was required, I made this claim because I was (still am) sure that I'd seen the question `"The item has been deleted; add to front? "` asked. However, going back, I've been unable to cause that condition to trigger, except by calling `browse-kill-ring-edit-finish` in a buffer that was not the edit buffer, which does not feel like something that should be supported.

So, I think this change could be merged, but equally, if someone would like to explain why the code I've removed is actually important, and how to trigger it, then I'm happy to drop this PR, and create another one that just adds a comment explaining things.