gds-operations/unicornherder — pull request #20 by zpencerq (2014-09-11 23:56:19+00:00)
Title: Remove unicorn_rails -P {pidfile} flag

`unicorn_rails` does not use the -P flag ([source](https://github.com/defunkt/unicorn/blob/master/bin/unicorn_rails#L78-L82)) to specify the location of its pid file
(it uses the accompanying configuration file). Unfortunately, including the -P
flag was causing `ENV['RAILS_RELATIVE_URL_ROOT']` to be overwritten with the
path to the unicorn pid (which is nonsensical).

It may be worthwhile to also remove the flags to the other unicorn commands as well, since those flags are deprecated ([source](https://github.com/defunkt/unicorn/blob/master/bin/unicorn#L70-L74)), and have unicornherder read the pidfile location from the accompanying unicorn configuration file (but that probably requires more code changes).