guardian/frontend — pull request #5899 by robertberry (2014-09-09 16:07:00+00:00)
Title: Fix missing image from Open Graph

```scala
override def openGraph: Map[String, String] = super.openGraph ++
Map("og:title" -> webTitle) ++
openGraphDescription.map { s => Map("og:description" -> s) }.getOrElse(Map()) // <-- OH NO
openGraphImage.map { s => Map("og:image" -> s)}.getOrElse(Map())
```

Because the `++` was missing there, it wasn't actually appending the image to the open graph data.

This manifested itself as a bizarre error on the admin box when rebuilding indexes. As that line wasn't part of the method definition it was invoked when the `Tag` object was initialised. One of the contributor tags contains crap data for the image url (thanks R2, for validating things like this!) -- i.e., it contains spaces, and this is passed through into the Java `Url` constructor somewhere further down the line, without anybody bothering to catch the exception it throws when something doesn't look like an url ...

So, yeah.

Also some unnecessary style changes that happened while I was investigating :angel: