mitchellh/goamz — pull request #99 by fatih (2014-09-09 13:46:19+00:00)
Title: ec2: add missing BlockDevice support for Instances() method

This was missing in the response so there was no way to obtain it. We
can't use the BlockDeviceMapping struct because the response in the
InstancesResp is different than the others. So we add a new
`BlockDevice` struct that represents the Block device response coming
from the instances resp. The response information can be found here:

http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeInstances.html

In the form of

```
block-device-mapping.attach-time
The attach time for an Amazon EBS volume mapped to the instance (for
example, 2010-09-15T17:15:20.000Z)

Type: DateTime

block-device-mapping.delete-on-termination
Indicates whether the Amazon EBS volume is deleted on instance
termination.

Type: Boolean

block-device-mapping.device-name
The device name (for example, /dev/sdh) for the Amazon EBS volume.

Type: String

block-device-mapping.status
The status for the Amazon EBS volume.

Type: String

Valid values: attaching | attached | detaching | detached

block-device-mapping.volume-id
The volume ID of the Amazon EBS volume.

Type: String
```

The test response was already containing the in the form of

```xml

/dev/sda1

vol-a082c1c9
attached
2010-08-17T01:15:21.000Z
false

```

Therefore I also included this missing case to the tests.