ipython/nbviewer — pull request #343 by spenczar (2014-09-10 00:08:44+00:00)
Title: fix bogus error if indexing is not turned on

`RenderingHandler.finish_notebook` throws an error when run locally without an index - it hits the line `self.index.index_notebook(download_url, nb, public)` and barfs because `NoSearch.index_notebook` expects 3 arguments, not 4.

`NoSearch.index_notebook` should just happily accept any arguments passed, notify debug that it wont index, and not raise errors. This should be independent of the call signature.

An alternative fix for this is to actually require 4 arguments for subclasses of `Indexer` - right now `ElasticSearch` uses 4 arguments but the abstract base class only expects 3. I think this fix is a little more robust, though.