closebuy/closebuy — pull request #61 by tylerlewis (2014-09-07 22:46:23+00:00)
Title: Fix camera routing bug by converting sell tabs to sell views

I want to give Lawrence a chance to look at this before it is merged in, as Dara and I had to make a subtle change to the sell-description module (services) and to the sell routing. We encountered a problem when we eliminated the sell tab and changed the camera tab's title to 'Sell' to reflect the idea that when a user clicks the sell tab, this initiates the camera-splash. The routing in app.js for the sell modules was looking for 'tab-sell', but this did not exist anymore. Therefore, after taking a picture, $state.go('tab.sell') did nothing at all. That is where the changes in app.js came from. I commented out the former tab-views and kept only the templateUrl's and controllers, effectively converting the sell-description and confirmation pages into views rather than attached to a tab. Obviously this is an important distinction, but Dara and I confirmed that the changes work on both iOS and Android. I just wanted everyone, especially Lawrence since they're his modules, to have a chance to review. If you need any more clarification on what the changes are doing, please let me know.