YaleSTC/shifts — pull request #363 by njlxyaoxinwei (2014-09-07 20:15:10+00:00)
Title: Modal windows

This pull request accomplishes multiple goals:

1. Complete removal of thickbox.js and convert __all__ modal windows to bootstrap with the remote option.
2. Forced reload of remote content everytime the modal window is launched.
3. Disable the submit button once it is clicked, to prevent multiple submission.
4. Non-modal, non-ajax forms can be reached through "open in a new tab/window" by right clicking the button/link, for those browsers that don't support Bootstrap that well.
5. Fix all form error handling: the error messages are now correctly displayed for all models involved.
6. Correct routing after non-ajax form submission when modals are not used.
7. Removal of all session[:mobile_param] conditions in all .js.erb files, since Bootstrap is now responsive.
8. Other minor fixes of deprecated methods and non-existent routes.

This pull request fixes #338 and the second part of #273