owncloud/core — pull request #10891 by PVince81 (2014-09-05 12:57:30+00:00)
Title: Catch exceptions when moving files

When moving files on storages that don't expose permissions, the storage
itself might throw an exception when the permission is denied.

This fix ensures that exceptions are caught and forwarded to the client
instead of just hanging.

Fixes https://github.com/owncloud/core/issues/10876

I tested it as follows:
1) Enable ext storage app
2) Enable SFTP storage
3) Edit `apps/files_external/lib/sftp.php`. In the `rename` function: add `throw new \OCP\Files\NotPermittedException("message")'
4) In the web UI, move a file inside a subdir of the storage
5) Change the exception to `\Exception("Test message")` to test the second case to catch any exception
6) Move a file again

Please review @th3fallen @icewind1991 @jmaciasportela