zfsonlinux/zfs — pull request #2665 by ilovezfs (2014-09-05 06:43:24+00:00)
Title: Fragmentation should display as '-' if spacemap_histogram=disabled

When com.delphix:spacemap_histogram is disabled, the value of
fragmentation was printing as 18446744073709551615 (UINT64_MAX),
when it should print as '-'.

The issue was caused by a small mistake during the merge of
"4980 metaslabs should have a fragmentation metric."

upstream:
https://github.com/illumos/illumos-gate/commit/2e4c998613148111f2fc5371085331ffb39122ff
ZOL:
https://github.com/zfsonlinux/zfs/commit/f3a7f6610f2df0217ba3b99099019417a954b673

The problem is in zpool_get_prop_literal, where the handling of the
pool property ZPOOL_PROP_FRAGMENTATION was added to wrong the
section. In particular, ZPOOL_PROP_FRAGMENTATION should not be in
the section where zpool_get_state(zhp) == POOL_STATE_UNAVAIL, but
lower down after it's already been determined that the pool is in
fact available, which is where upstream illumos correctly has had
it.

Thanks to lundman for helping to track down this bug.

Issue https://github.com/zfsonlinux/zfs/issues/2664