facebook/rocksdb — pull request #271 by nbougalis (2014-09-05 03:57:52+00:00)
Title: Cleanups

This changeset plus a memory leak that exists in `DocumentDBImpl::CreateIndex`: if `CreateColumnFamily` fails, then we never deallocate the `Index` that we allocated a few lines back.

Additionally, the variable names used in `VersionEdit::AddFile` where swapped, which could cause confusion when reviewing the code. Fix the issue. Note that all the call sites are *correctly* passing the arguments in and the problem is entirely localized in `AddFile`.