opscode/chef — pull request #1978 by jdmundrawala (2014-09-03 23:27:33+00:00)
Title: lcm parser is a lot more forgiving

@adamedx @btm @randomcamel
This change makes the parser a lot more forgiving. It makes it so that the default value of a dsc resource is that it needs to be converged, and only if it sees a skip will it skip it.

One thing to note is that the only places we have seen neither a skip or a start/end resource message is when there has been an error coming back from the lcm, so we would still correctly converge the node without this change.

Also, the diff on the spec is not easily readable...sorry. I've deleted 2 tests that made sure the parser threw an exception if it got back some crazy output that we now just try to recover from and added one to make sure we default to saying the resource is not converged.