elasticsearch/elasticsearch — pull request #7550 by mikemccand (2014-09-03 10:03:05+00:00)
Title: make indices.memory.index_buffer_size dynamically updatable

This is PR for #7045

It also makes related settings (min/max_index_buffer_size and min/max_shard_index_buffer_size dynamically updatable.

But I have some concerns I wasn't sure about. First, whether the ShardsIndicesStatusChecker.run (the methods that "bubbles down" the allowed RAM to all active shards) is thread-safe or not since it can now be called from two threads at once. Probably I will just put a lock around it to be safe ...

Second, I just added these to ClusterDynamicSettingsModule, yet I use NodeSettingsService.addListener to subscribe to changes; is this right? Also, in the test, I'm using "persistent" cluster settings, but I'm not familiar with this (where do these changes persist?) and I couldn't figure out how to do a full restart and confirm the dynamic changes did in fact persist somewhere ... so I could use some pointers here :)