Dgrady3/systems_check_3 — pull request #1 by hchood (2014-09-02 18:48:03+00:00)
Title: Hh refactor

Hi Joe,

Nice work! Your systems check looked great. Nice use of `exec_params`. I made a few edits in this pull request, but nothing major. The main change I made was to refactor the queries in your `get` blocks into methods. The only other notes I'd make are:

1. Try to get into the habit of making more atomic (i.e. smaller, more frequent) commits. When you're done with a get block & method, for example, commit. Then commit again when you've got the view finished. For these small apps it's not a huge deal if you're not committing that frequently, but once you get to larger apps with lots more files it's better to commit often so that you can easily roll back to a prior state if you break something.

2. I'd give the `@details` instance variable a more specific name, like `@recipe_info`. Alternatively, I might create two instance variables: `@recipe`, containing the recipe name, description, and instructions, and `@ingredients`, containing each ingredient's info. Then you don't have things like `@details[0]["instructions"]` in your view, which is a little unwieldy.

Also, make sure to make your systems checks repos private going forward :)

Helen