python-pillow/Pillow — pull request #882 by hugovk (2014-09-02 13:54:35+00:00)
Title: Tests and access functions for Effects.c

Effects.c has four main functions:

* ImagingEffectMandelbrot
* ImagingEffectNoise
* ImagingEffectPerlinTurbulence
* ImagingEffectSpread

ImagingEffectMandelbrot
---

This has Python access functions in _imaging.c, but nothing in Image.py. I added a test and a function in Image.py.

ImagingEffectNoise
---

This has Python access functions in _imaging.c, but nothing in Image.py. I added a test and a function in Image.py.

It passes on Windows (and produces a correct-looking image) but stalls on Travis CI (Linux). I can't debug it right now, so have skipped the test on non-Windows.

What should be done with this?
* Debug/fix it?
* Remove it entirely?
* Remove the new access function for the time being?
* Leave it like this?

ImagingEffectPerlinTurbulence
---

ImagingEffectPerlinTurbulence is "in progress" since 2003 and does nothing except return NULL. Its helper functions are all behind an #if 0.

I removed it.

ImagingEffectSpread
---

This has Python access functions in _imaging.c, but nothing in Image.py. I added a test and a function in Image.py.

---

* Helps towards: Test coverage >= 80% #722.