mpc-hc/mpc-hc — pull request #141 by Robo210 (2014-09-01 02:08:13+00:00)
Title: Fix typo in DVB subtitle parser.

I haven't test this, but I think this fixes an unintentional "foo = foo" bug on line 236 and restores the use of the computation of m_rtStart from pts.

I suspect there is still an issue with this change. The older version of this file (acb7f94) seemed to use the computation of pts if and only if `pSample->GetTime(...)` and `pSample(GetMediaTime(...)` both failed. As of 733bc17, however, that should never happen as `SubtitleInputPin::Receive(...)` (the only caller of ParseSample I believe) will fail if `GetTime(...)` fails, and so the start and end times passed in to this function are guaranteed to be valid. This means before 733bc17 `m_rtStart = pts` was always getting overwritten a few lines down, and can be removed entirely.

Since I'm not really confident that the above is 100% correct and I don't know how to test this, I'm just submitting the change as is with that somebody more familiar with the code can chime in and point out if I'm wrong or not.