reviewninja/review.ninja — pull request #312 by pdehaan (2014-08-31 16:51:31+00:00)
Title: Minor formatting per ESLint feedback

A bit of formatting tweaks based on ESLint feedback. Clean code is happy code.

Current ESLint feedback is:
```sh
$ eslint {,src/}*.js src/{client,server,tests}

src/client/api.js
5:0 error Missing "use strict" statement strict

src/server/api/github.js
30:52 error Expected error to be handled handle-callback-err

src/server/api/user.js
27:15 error Expected error to be handled handle-callback-err

src/server/app.js
93:20 error Expected error to be handled handle-callback-err
119:20 error Expected error to be handled handle-callback-err
140:20 error Expected error to be handled handle-callback-err
166:20 error Expected error to be handled handle-callback-err
187:20 error Expected error to be handled handle-callback-err
199:3 error Expected error to be handled handle-callback-err
213:8 error Expected an assignment or function call and instead saw an expression no-unused-expressions

src/server/passports/github.js
26:11 error Expected error to be handled handle-callback-err

src/server/services/status.js
22:15 error Expected error to be handled handle-callback-err
8:57 error Expected error to be handled handle-callback-err

src/server/webhooks/issues.js
56:41 error Expected error to be handled handle-callback-err

src/server/webhooks/pull_request.js
16:41 error Expected error to be handled handle-callback-err

src/server/wrap/gitdata.js
11:12 error 'res' is not defined no-undef

src/server/wrap/search.js
18:15 error Expected error to be handled handle-callback-err

src/tests/server/api/issue.js
48:23 error Expected error to be handled handle-callback-err
85:23 error Expected error to be handled handle-callback-err

src/tests/server/api/settings.js
27:26 error Expected error to be handled handle-callback-err
47:26 error Expected error to be handled handle-callback-err

src/tests/server/api/star.js
62:22 error Expected error to be handled handle-callback-err
278:22 error Expected error to be handled handle-callback-err

src/tests/server/api/webhook.js
76:25 error Expected error to be handled handle-callback-err
108:25 error Expected error to be handled handle-callback-err
128:28 error Expected error to be handled handle-callback-err
170:28 error Expected error to be handled handle-callback-err

✖ 27 problems
```

Fixes #311 (kinda sorta). I'll claim that this addresses the formatting aspects of #311 and the errors listed above are "bugs" and I'll file a separate bug for easier tracking/discussion/arguing.