kickstarter/rack-attack — pull request #85 by ktheory (2014-08-31 01:33:14+00:00)
Title: Add 1 second buffer to expiry to correct throttles

Fixes #69.

There was a race condition when `Time.now.to_i` changes between when
`epoch_time` is computed in line 18, and the cache request is made (and
the `key` is expired).

I.e., a throttle check starts at t0, but doesn’t reach the cache until
t1, the cache will have expired the throttle count. The request will
likely be allowed, even if the request exceeded the limit.

This has the effect of keeping keys in cache about 1 second longer than
strictly necessary. But the extra cache space seems like a good
trade-off for correct throttling.

Looking for a sanity check/:+1: from @zmillman before merging.