tomekw/hikari-cp — pull request #1 by devn (2014-08-30 20:23:03+00:00)
Title: If using JTDS, set portNumber and serverName separately

When trying to get HikariCP working with SQL Server and the JTDS DataSource I ran into some trouble. I found that `portNumber` (note: not `port` in this case) needed to be set independently from `serverName`, otherwise it would throw an `UnknownHostException`.

I believe there is a similar issue when using the Microsoft SQL Server driver, but I did not take the time to figure it out as I only required JTDS.

Perhaps a better way to handle this would be to simply add something to the README to let people know that they may need to override DataSourceProperties depending on which driver they're using and reference the relevant documentation. In this case, a link to http://jtds.sourceforge.net/doc/net/sourceforge/jtds/jdbcx/JtdsDataSource.html with a small blurb explaining how `setFooBar` is related to the property `fooBar` on a driver level would have saved me some time.

Thanks,
Devin