akkadotnet/akka.net — pull request #353 by Aaronontheweb (2014-08-29 20:42:39+00:00)
Title: fixed bug with remote deployment tests

Fixes a bug inside the `RemoteDaemonSpec`, but I think it's worth discussing the implications of some changes I made in #347

Specifically, this change: https://github.com/Aaronontheweb/akka.net/commit/2470bafb2e8fc34e3e87ea70686a4de20b4645ec#diff-b555495dc1069ee340aa7b01e3130fb1L134 - it drops the extra "/remote" from the front of the actor path, so you don't end up with `akka.tcp://system@localhost:{port}/remote/remote/....` - the `/remote` automatically gets appended to the remote-deployed actor's name when the `RemoteDaemon` creates it.

This brings the `RemoteDaemon` inline with how Akka behaves, this bit specifically: https://github.com/akka/akka/blob/master/akka-remote/src/main/scala/akka/remote/RemoteDaemon.scala#L148

Are there any scenarios we can think of where this change might create some problems for an end-user? I can't think of any since it seems like remote deployment's been broken for a while, but am I overlooking anything?