sahat/satellizer — pull request #71 by Foxandxss (2014-08-28 12:16:12+00:00)
Title: Group test injections, better testing

Today is the test day, my first goal was to do a little cleanup, there is no changes about the test themselves (that is my next step probably).

So, for DRY, I moved all the injection in all the files to the top (you were doing that in some files).

`$authSpec`, moved injections at the top, so when the naming changes come (lowercase services), it is better to change just one place and not 20.

Also, I added an `afterEach`. Basically you were testing like: This method MAY do a request. The idea is: it MAY and we ASSERT that. You were missing the last part. So the idea is: We establish what request are going to be done and that only those are made. If there is an extra request, please fail, if there is a request expected but not done, fail. That is what the `afterEach` does.

`testConfig`, changed `authProvider` to `$authProvider` makes more sense.

`localSpec`, same changes as `$authSpec`. Funny enough, you had a little error on one of the tests where you expected `Local.unlink()` to be defined. Well, defined is, but you were actually calling the function and that generated a non expected `GET`. With the `afterEach` that cries (good) so I just fixed the typo.

The rest of the tests are just minimum changes.

Next, check what tests makes sense. Which remembers me... the provider test, all those tests where you put a string and then test that the string is there are worthless. Luckily, if we do the constants again, that tests are going to change and make more sense.

Cheers.