project-hatohol/hatohol — pull request #457 by kz0817 (2014-08-26 04:10:09+00:00)
Title: Clenaup test 5

These patches clean up test code that uses a database.
Previously test DBs are created, deleted and used in the various places including helper functions whose code is not seen at a glance. This fact degrades readability very much.

So the guild line to write test with test DB has been decided as in DBTablesTest.h
And I fixed test according to it.

Basically, setupTestDB() that delete and create a test DB is allowed to be called once
only in cut_setup(). So developper don't be worried that the database is destroyed in
the middle of the test.

In addtion, this clean up also has another purpose. It reduces the dependency of
actual database such SQLite3 and MySQL. For example, the previous code
assumes that DBTablesMonitoring is stored in SQLite3 and uses defineDBPath()
that needs SQLite3. These fixes also remove the explicit call of that.

Note that we still have tasks that remove unused method and do more clean up.
However, this pull request is already huge, so I'll do them as an another topic.