McCraftaholics/Bukkit-WarpPortals — pull request #26 by xxyy (2014-08-25 03:17:13+00:00)
Title: Fix Nether portals not vanishing when frame destroyed

**The issue:**
In the current build of this plugin, players are not able to destroy nether portals since when they destroy any part of the Obsidian frame, the Portal blocks don't vanish. (Vanilla/Spigot behaviour: Portal disappears when Obsidian destroyed) However, admins may wish to run this plugin on a server which allows normal players to destroy native Nether portals. (I had players complain about this)
**PR Breakdown:**
This PR adds an extra check to the `BlockPhysicsEvent` handler which makes sure that we don't cancel physics events caused by Obsidian blocks (aka. native Nether portals being destroyed).
**Potential problems:**
Although this resolves the issue for me, it might be better to check whether the event was fired for an actual WarpPortal block instead.
**Testing materials:**
I have tested that this change resolves mentioned issue and this is also running in a Production environment. However, I have **not** tested whether this change affects the initial behaviour of the `BlockPhysicsEvent` handler. (It's 5am now, I can do this later if desired and if I get a full explanation what it's supposed to do - I didn't quite get that)

Thanks!